aMule Bug Tracker - aMule
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001715aMuleMiscpublic2012-04-03 13:522012-05-12 07:37
Reporterbrand77 
Assigned Tosturedman 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version2.3.2 
Fixed in Revision10772
Operating SystemAny
Summary0001715: Can't build on fedora 17
DescriptionI can't build on fedora 17 with this error:

In file included from DownloadQueue.h:30:0,
                 from DownloadQueue.cpp:26:
ObservableQueue.h: In instantiation of ‘void CObservableQueue<ValueType>::ObserverAdded(CObservableQueue<ValueType>::ObserverType*) [with ValueType = CPartFile*; CObservableQueue<ValueType>::ObserverType = CObserver<CQueueEvent<CPartFile*> >]':
DownloadQueue.cpp:1528:32: required from here
ObservableQueue.h:334:2: error: ‘NotifyObservers' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
ObservableQueue.h:334:2: note: declarations in dependent base ‘CObservable<CQueueEvent<CPartFile*> >' are not found by unqualified lookup
ObservableQueue.h:334:2: note: use ‘this->NotifyObservers' instead
ObservableQueue.h: In instantiation of ‘void CObservableQueue<ValueType>::ObserverRemoved(CObservableQueue<ValueType>::ObserverType*) [with ValueType = CPartFile*; CObservableQueue<ValueType>::ObserverType = CObserver<CQueueEvent<CPartFile*> >]':
DownloadQueue.cpp:1665:1: required from here
ObservableQueue.h:341:2: error: ‘NotifyObservers' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
ObservableQueue.h:341:2: note: declarations in dependent base ‘CObservable<CQueueEvent<CPartFile*> >' are not found by unqualified lookup
ObservableQueue.h:341:2: note: use ‘this->NotifyObservers' instead
make[3]: *** [amule-DownloadQueue.o] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

This little patch solve the problem:

diff aMule-2.3.1/src/ObservableQueue.h.old aMule-2.3.1/src/ObservableQueue.h
334c334
< NotifyObservers( EventType( EventType::STARTING ), o );
---
> this->NotifyObservers( EventType( EventType::STARTING ), o );
341c341
< NotifyObservers( EventType( EventType::STOPPING ), o );
---
> this->NotifyObservers( EventType( EventType::STOPPING ), o );

Steps To Reproduce
Additional InformationThe problem is GCC 4.7, not Fedora.
TagsNo tags attached.
Relationships
has duplicate 0001718resolved sturedman unable to compile 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-04-03 13:52brand77New Issue
2012-04-03 13:52brand77Operating System => Any
2012-04-03 13:54brand77Note Added: 0003623
2012-04-11 16:19sturedmanFixed in Revision => 10772
2012-04-11 16:19sturedmanNote Added: 0003624
2012-04-11 16:19sturedmanAssigned To => sturedman
2012-04-11 16:19sturedmanStatusnew => resolved
2012-04-11 16:19sturedmanResolutionopen => fixed
2012-04-11 16:19sturedmanCategoryGUI => Misc
2012-04-11 16:19sturedmanAdditional Information Updated
2012-05-12 07:37GonoszTopiFixed in Version => 2.3.2
2012-05-12 07:38GonoszTopiRelationship addedhas duplicate 0001718

Notes
(0003623)
brand77   
2012-04-03 13:54   
wrong category, nothing to do with GUI... how to move?
(0003624)
sturedman   
2012-04-11 16:19   
Thank you!