aMule Bug Tracker - aMule
View Issue Details
0001716aMuleMiscpublic2012-04-08 00:002012-05-12 07:46
resolvedwon't fix 
0001716: src/libs/ec/cpp/ doesn't use standard *FLAGS for compilation
this has been reported in Debian at:

The hardening flags are missing for mkFileSum.c because the build
system doesn't use them.

The attached patch fixes the issue - but I'm not sure if it's the
best way, I have no idea why the build system use BUILD_*FLAGS
variables instead of just *FLAGS. If possible it should be sent
upstream (maybe in modified form).

Indeed at least all the other Makefiles uses either both BUILD_*FLAGS or just the standard CFLAGS LDFLAGS CPPFLAGS, but not the makefile for mkFileSum.c .

The patch attached simply remove BUILD_ from those flags, so that the standard flags are used (needed in Debian to pass additional compilation flags, for hardening binaries).

No tags attached.
diff libs-use-dpkg-buildflags.diff (1,103) 2012-04-08 00:00
Issue History
2012-04-08 00:00morphNew Issue
2012-04-08 00:00morphFile Added: libs-use-dpkg-buildflags.diff
2012-04-08 00:00morphOperating System => Any
2012-04-11 16:52sturedmanFixed in Revision => 10773
2012-04-11 16:52sturedmanNote Added: 0003625
2012-04-11 16:52sturedmanStatusnew => resolved
2012-04-11 16:52sturedmanResolutionopen => fixed
2012-04-11 21:29sturedmanAssigned To => sturedman
2012-04-11 21:29sturedmanStatusresolved => feedback
2012-04-11 21:29sturedmanResolutionfixed => reopened
2012-04-11 21:30sturedmanNote Added: 0003626
2012-04-11 21:30sturedmanStatusfeedback => resolved
2012-04-11 21:30sturedmanResolutionreopened => fixed
2012-04-29 18:24sturedmanNote Added: 0003627
2012-04-29 18:24sturedmanStatusresolved => feedback
2012-04-29 18:24sturedmanResolutionfixed => reopened
2012-04-29 18:25sturedmanStatusfeedback => assigned
2012-05-12 07:42GonoszTopiAssigned Tosturedman =>
2012-05-12 07:42GonoszTopiStatusassigned => resolved
2012-05-12 07:42GonoszTopiResolutionreopened => won't fix
2012-05-12 07:46GonoszTopiAssigned To => sturedman

2012-04-11 16:52   
I committed the patch directly (the part modifying a versioned file at least).
Mind, this is just a little build helper tool we are talking about. It's not supposed to be shipped with a binary package anyway.
2012-04-11 21:30   
Stupid Mantis listing resolved bugs as "unassigned"
2012-04-29 18:24   
This patch is not only useless (mkFileSum is just a build tool), it also breaks cross compilation. See [^]