aMule Bug Tracker - aMule
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000209aMuleMulti Platformpublic2004-11-23 16:182005-03-13 18:33
ReporterD10Tmain 
Assigned Token 
PrioritynormalSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformIBM rs6k powerpc3OSLinuxOS VersionFC ppc64
Product Version2.0.0-rc8 
Target VersionFixed in Version 
Fixed in Revision
Operating System
Summary0000209: byte order !!! ipfilter/others
DescriptionHardware: ibm rs6k, cpu-powerpc3
OS: Fedora Core ppc/ppc64 development tree
There is a byteorder conversion bug !!!
Symptom:
real connection from IP: A.B.C.D
in log: ipfilter not declared ip D.C.B.A (or similar-ip reversed)
with ipfilter switched off transfers works ok

the some with messages:
mesage from ip A.B.C.D (real)
and in info: new messages from D.C.B.A (ip reversed)
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2004-11-23 16:18D10TmainNew Issue
2004-12-08 01:37KryStatusnew => assigned
2004-12-08 01:37KryAssigned To => Kry
2004-12-08 01:40KryNote Added: 0000427
2004-12-08 13:49D10TmainNote Added: 0000434
2004-12-08 13:50D10TmainNote Edited: 0000434
2004-12-08 15:15D10TmainNote Edited: 0000434
2004-12-08 16:05D10TmainNote Added: 0000435
2004-12-08 16:21D10TmainNote Edited: 0000435
2004-12-08 16:22D10TmainNote Edited: 0000435
2004-12-09 19:25KryNote Added: 0000447
2004-12-10 23:55D10TmainNote Added: 0000449
2004-12-11 00:04D10TmainNote Edited: 0000449
2004-12-12 18:27KryNote Added: 0000451
2004-12-13 11:59D10TmainNote Added: 0000453
2005-01-07 04:26KryAssigned ToKry => ken
2005-01-16 17:54XaignarStatusassigned => resolved
2005-01-16 17:54XaignarResolutionopen => fixed
2005-01-16 17:54XaignarNote Added: 0000513
2005-01-26 03:55phoenixStatusresolved => feedback
2005-01-26 03:55phoenixResolutionfixed => reopened
2005-01-26 03:55phoenixNote Added: 0000557
2005-01-27 13:13phoenixResolutionreopened => fixed
2005-01-28 01:45D10TmainNote Added: 0000575
2005-01-28 01:48D10TmainNote Edited: 0000575
2005-01-29 03:51phoenixResolutionfixed => reopened
2005-01-29 03:51phoenixOS => Linux
2005-01-29 03:51phoenixOS Version => FC ppc64
2005-01-29 03:51phoenixPlatform => IBM rs6k powerpc3
2005-01-29 03:51phoenixProduct Version2.0.0-rc7 => 2.0.0-rc8
2005-02-09 13:16D10TmainNote Edited: 0000575
2005-02-09 13:17D10TmainNote Edited: 0000575
2005-03-13 18:33kenStatusfeedback => resolved
2005-03-13 18:33kenResolutionreopened => fixed
2005-03-13 18:33kenNote Added: 0000740

Notes
(0000427)
Kry   
2004-12-08 01:40   
Can you try a recent cvs version? I fixed a handful of endianess issues and it's working ok on MacOS.

Thansks for reporting, very useful info :)
(0000434)
D10Tmain   
2004-12-08 13:49   
(edited on: 2004-12-08 15:15)
recompiled cvs 2004.12.08

connection to servers ok
ipfilter list loaded from url ok

bug : ipfilter.dat save - addresses saved in reversed order (a.b.c.d - saved as d.c.b.a :-( )
manualy created ipfilter.dat with correct entries - reload from ipfilter.dat works ok
corrected in IPFilter.cpp function void CIPFilter::SaveToFile():
...
        IPListMap::iterator it = iplist.begin();
        while(it != iplist.end()) {
                wxString line;
                in_addr ip;
                // Range Start
                ip.s_addr=htonl(it->second->IPStart);
                line += inet_ntoa(ip);
                // Make it nice
                for (uint32 i = line.Len(); i < 15; i++) { // 15 -> "xxx.xxx.xxx.xxx"
                        line += wxT(" ");
                }
                // Range Separator
                line += wxT(" - ");
                // Range End
                ip.s_addr=htonl(it->second->IPEnd);
                line += inet_ntoa(ip);
                // Make it nice
                for (uint32 i = line.Len(); i < 33; i++) { // 33 -> "xxx.xxx.xxx.xxx - yyy.yyy.yyy.yyy"
                        line += wxT(" ");
...
recompiled - works ok


still testing other things

reg.

edited on: 12-08-04 13:50

edited on: 12-08-04 15:15
(0000435)
D10Tmain   
2004-12-08 16:05   
(edited on: 2004-12-08 16:22)
bug: download/upload nothing
i can send/receive messages to/from client a.b.c.d

12/08/2004 03:43:00 PM: Packet received from a.b.c.d <- ok
12/08/2004 03:43:00 PM: Packet received from d.c.b.a <- reversed
12/08/2004 03:43:00 PM: SUIS: IS_KEYANDSIGNEEDED
12/08/2004 03:43:00 PM: YO happened for client: "client name"
12/08/2004 03:43:00 PM: Packet received from d.c.b.a <-reversed
12/08/2004 03:43:01 PM: Packet received from d.c.b.a <-reversed
12/08/2004 03:45:32 PM: Packet received from d.c.b.a <-reversed
12/08/2004 03:45:32 PM: New message from 'client name' (IP:d.c.b.a) <-reversed
12/08/2004 03:45:32 PM: Packet received from d.c.b.a <-reversed
12/08/2004 03:45:36 PM: Packet received from d.c.b.a <-reversed

message from client a.b.c.d in log i got:
12/08/2004 04:27:07 PM: Not sending SecIdentState Packet, because State is Zero
12/08/2004 04:27:07 PM: Packet received from d.c.b.a <-reversed
12/08/2004 04:27:07 PM: SUIS: IS_SIGNATURENEEDED
12/08/2004 04:27:07 PM: Packet received from d.c.b.a <-reversed
12/08/2004 04:27:07 PM: New message from 'clientname' (IP:d.c.b.a) <-reversed

edited on: 12-08-04 16:21

edited on: 12-08-04 16:22
(0000447)
Kry   
2004-12-09 19:25   
Where are you getting CVS versions? Because your ipfilter code looks totally different from mine.
(0000449)
D10Tmain   
2004-12-10 23:55   
(edited on: 2004-12-11 00:04)
cvs`s code i`ve got from http://amule.hirnriss.net/cvs/aMule-cvs-20041208.tar.bz2 [^]
ipfilter.dat generated by this cvs version has entries with reversed bytes:
0.0.0.0 255.255.255.3 which shoud be 0.0.0.0 3.255.255.255

I`ve changed code in IPFilter.cpp to version posted before.
And changed version worked ok. (in aspect of ipfilter - reloading, getting from external sources)

edited on: 12-11-04 00:04
(0000451)
Kry   
2004-12-12 18:27   
Fixed IPFilter on current CVS. Strange MacOS is getting up/down transfers correctly.
(0000453)
D10Tmain   
2004-12-13 11:59   
cvs snapshot 20041213:
IPFilter works ok
Connecting to servers ~ok

on log (no transfers):

12/13/2004 11:56:56 AM: Connecting to Razorback 2 (195.245.244.243 - 195.245.244.243:4661)
12/13/2004 11:56:56 AM: Server 195.245.244.243 Port 4661
12/13/2004 11:56:56 AM: Addr razorback.ed2k.ch Port 4661
12/13/2004 11:56:56 AM: Connected to Razorback 2 (195.245.244.243:4661)
12/13/2004 11:56:56 AM: Remote Client: OP_HELLO
12/13/2004 11:56:56 AM: Local Client: OP_EMULEINFO to 241.244.245.195 <-- reversed
12/13/2004 11:56:56 AM: Local Client: OP_HELLOANSWER to
241.244.245.195 <-- reversed
12/13/2004 11:56:56 AM: Connection established on: Razorback 2
12/13/2004 11:56:56 AM: New client ID is xxxxxxxxxxx
12/13/2004 11:56:56 AM: Received 54 new servers
12/13/2004 11:56:56 AM: Saving of server-list completed.
12/13/2004 11:56:58 AM: Local Client: OP_HELLO to
a.b.8.230
12/13/2004 11:56:58 AM: Packet received from a.b.8.230 <-- ip ok
12/13/2004 11:56:58 AM: Remote Client: OP_HELLOANSWER
12/13/2004 11:56:58 AM: Local Client: OP_SECIDENTSTATE
12/13/2004 11:56:58 AM: Packet received from 230.8.b.a <-- ip reversed
12/13/2004 11:56:58 AM: Remote Client: OP_SECIDENTSTATE
12/13/2004 11:56:58 AM: SUIS: IS_SIGNATURENEEDED
12/13/2004 11:56:58 AM: Packet received from 230.8.b.a <-- ip reversed
12/13/2004 11:56:58 AM: Remote Client: OP_PUBLICKEY
12/13/2004 11:56:58 AM: Local Client: OP_SIGNATURE
12/13/2004 11:56:58 AM: Packet received from 230.8.b.a <-- ip reversed
12/13/2004 11:56:58 AM: Remote Client: OP_SIGNATURE
12/13/2004 11:56:58 AM: Packet received from 230.8.b.a <-- ip reversed
12/13/2004 11:56:58 AM: Remote Client: OP_MULTIPACKETANSWER
12/13/2004 11:57:00 AM: Packet received from 230.8.b.a <-- ip reversed
12/13/2004 11:57:00 AM: Remote Client: OP_QUEUERANKING
12/13/2004 11:57:00 AM: Packet received from 230.8.b.a <-- ip reversed
12/13/2004 11:57:00 AM: Remote Client: OP_MULTIPACKET
12/13/2004 11:57:41 AM: Client 'xxxxx' (IP:230.8.b.a) caused a socket blocking error. Retries: 0. Trying to reconnect... (retries left: 2) <-- ip reversed
12/13/2004 11:58:02 AM: Disconnected
(0000513)
Xaignar   
2005-01-16 17:54   
AFAIK, this has been fixed on CVS.
(0000557)
phoenix   
2005-01-26 03:55   
Is this still an issue?
(0000575)
D10Tmain   
2005-01-28 01:45   
(edited on: 2005-02-09 13:17)
tested cvs version 20050127
still issue as on previous report (20041213) :-(
additionaly problem with ipfilter:

01/28/2005 01:41:32 AM: Filtered IP: 83.29.10.51(Not declared)
01/28/2005 01:41:32 AM: Filtered IP: 84.234.44.21(Invalid)
01/28/2005 01:41:32 AM: Filtered IP: 83.30.27.165(Not declared)
01/28/2005 01:41:32 AM: Filtered IP: 84.140.204.76(Not declared)
01/28/2005 01:41:32 AM: Filtered IP: 83.17.4.2(Not declared)
addresses displayed correctly but should not be filtered (are out of the ipfilter list)
on the ipfilter list there are reversed addresses 51.10.29.83, 21.44.234.84, 165.27.30.83, 2.4.17.83

tested cvs version 20050207 - still issue

edited on: 02-09-05 13:17
(0000740)
ken   
2005-03-13 18:33   
I believe this is fixed on CVS. Re-open if not.