aMule Bug Tracker - aMule
View Issue Details
0001107aMuleMiscpublic2007-05-24 15:132008-03-24 23:40
frederich 
Kry 
normalmajoralways
closedopen 
SVN 
 
Any
0001107: multiple errors in CryptoPP found by valgrind
Valgrind has found numerous errors in CryptoPP, with amule cvs 2007/05/24
==13793== Use of uninitialised value of size 4
==13793== at 0x82BE721: CryptoPP::RawDES::RawProcessBlock(unsigned&, unsigned&) const (CryptoPP.cpp:9300)
==13793== by 0x82BE7F8: CryptoPP::DES_EDE3::Base::ProcessAndXorBlock(unsigned char const*, unsigned char const*, unsigned char*) const (CryptoPP.cpp:9322)
==13793== by 0x82E031D: CryptoPP::BlockTransformation::ProcessBlock(unsigned char*) const (CryptoPP.h:813)
==13793== by 0x82D3769: CryptoPP::X917RNG::X917RNG(CryptoPP::BlockTransformation*, unsigned char const*, unsigned long) (CryptoPP.cpp:9493)
==13793== by 0x805E037: CryptoPP::AutoSeededX917RNG<CryptoPP::DES_EDE3>::Reseed(unsigned char const*, unsigned, unsigned char const*, unsigned long) (CryptoPP.h:6710)
==13793== by 0x805E1DA: CryptoPP::AutoSeededX917RNG<CryptoPP::DES_EDE3>::Reseed(bool) (CryptoPP.h:6731)
==13793== by 0x805E279: CryptoPP::AutoSeededX917RNG<CryptoPP::DES_EDE3>::AutoSeededX917RNG(bool) (CryptoPP.h:6691)
==13793== by 0x809A3FA: CClientCreditsList::CreateSignature(CClientCredits*, unsigned char*, unsigned char, unsigned, unsigned char, void*) (ClientCreditsList.cpp:344)
==13793== by 0x807432E: CUpDownClient::SendSignaturePacket() (BaseClient.cpp:1951)
==13793== by 0x8074613: CUpDownClient::ProcessPublicKeyPacket(unsigned char const*, unsigned) (BaseClient.cpp:1987)
==13793== by 0x80AF262: CClientTCPSocket::ProcessExtPacket(unsigned char const*, unsigned, unsigned char) (ClientTCPSocket.cpp:1379)
==13793== by 0x80BB514: CClientTCPSocket::PacketReceived(CPacket*) (ClientTCPSocket.cpp:2002)


==13793== Conditional jump or move depends on uninitialised value(s)
==13793== at 0x805C699: CryptoPP::AutoSeededX917RNG<CryptoPP::DES_EDE3>::GenerateByte() (CryptoPP.h:6740)
==13793== by 0x82B3D6B: CryptoPP::RandomNumberGenerator::GenerateBlock(unsigned char*, unsigned) (CryptoPP.cpp:237)
==13793== by 0x82CEF9D: CryptoPP::Integer::Randomize(CryptoPP::RandomNumberGenerator&, unsigned) (CryptoPP.cpp:4340)
==13793== by 0x82CF192: CryptoPP::Integer::Randomize(CryptoPP::RandomNumberGenerator&, CryptoPP::Integer const&, CryptoPP::Integer const&) (CryptoPP.cpp:4356)
==13793== by 0x82DF12E: CryptoPP::InvertibleRSAFunction::CalculateInverse(CryptoPP::RandomNumberGenerator&, CryptoPP::Integer const&) const (CryptoPP.cpp:7927)
==13793== by 0x809D8D3: CryptoPP::TrapdoorFunctionInverse::CalculateRandomizedInverse(CryptoPP::RandomNumberGenerator&, CryptoPP::Integer const&) const (CryptoPP.h:5003)
==13793== by 0x82CF536: CryptoPP::TF_SignerBase::SignAndRestart(CryptoPP::RandomNumberGenerator&, CryptoPP::PK_MessageAccumulator&, unsigned char*, bool) const (CryptoPP.cpp:6970)
==13793== by 0x82D1A58: CryptoPP::PK_Signer::SignMessage(CryptoPP::RandomNumberGenerator&, unsigned char const*, unsigned, unsigned char*) const (CryptoPP.cpp:697)
==13793== by 0x809A4E9: CClientCreditsList::CreateSignature(CClientCredits*, unsigned char*, unsigned char, unsigned, unsigned char, void*) (ClientCreditsList.cpp:359)
==13793== by 0x807432E: CUpDownClient::SendSignaturePacket() (BaseClient.cpp:1951)
==13793== by 0x8074613: CUpDownClient::ProcessPublicKeyPacket(unsigned char const*, unsigned) (BaseClient.cpp:1987)
==13793== by 0x80AF262: CClientTCPSocket::ProcessExtPacket(unsigned char const*, unsigned, unsigned char) (ClientTCPSocket.cpp:1379)

==13793== Conditional jump or move depends on uninitialised value(s)
==13793== at 0x82C8D86: CryptoPP::Integer::Decode(CryptoPP::BufferedTransformation&, unsigned, CryptoPP::Integer::Signedness) (CryptoPP.cpp:4213)
==13793== by 0x82CEF1B: CryptoPP::Integer::Decode(unsigned char const*, unsigned, CryptoPP::Integer::Signedness) (CryptoPP.cpp:4202)
==13793== by 0x82CF010: CryptoPP::Integer::Randomize(CryptoPP::RandomNumberGenerator&, unsigned) (CryptoPP.cpp:4343)
==13793== by 0x82CF192: CryptoPP::Integer::Randomize(CryptoPP::RandomNumberGenerator&, CryptoPP::Integer const&, CryptoPP::Integer const&) (CryptoPP.cpp:4356)
==13793== by 0x82DF12E: CryptoPP::InvertibleRSAFunction::CalculateInverse(CryptoPP::RandomNumberGenerator&, CryptoPP::Integer const&) const (CryptoPP.cpp:7927)
==13793== by 0x809D8D3: CryptoPP::TrapdoorFunctionInverse::CalculateRandomizedInverse(CryptoPP::RandomNumberGenerator&, CryptoPP::Integer const&) const (CryptoPP.h:5003)
==13793== by 0x82CF536: CryptoPP::TF_SignerBase::SignAndRestart(CryptoPP::RandomNumberGenerator&, CryptoPP::PK_MessageAccumulator&, unsigned char*, bool) const (CryptoPP.cpp:6970)
==13793== by 0x82D1A58: CryptoPP::PK_Signer::SignMessage(CryptoPP::RandomNumberGenerator&, unsigned char const*, unsigned, unsigned char*) const (CryptoPP.cpp:697)
==13793== by 0x809A4E9: CClientCreditsList::CreateSignature(CClientCredits*, unsigned char*, unsigned char, unsigned, unsigned char, void*) (ClientCreditsList.cpp:359)
==13793== by 0x807432E: CUpDownClient::SendSignaturePacket() (BaseClient.cpp:1951)
==13793== by 0x8074613: CUpDownClient::ProcessPublicKeyPacket(unsigned char const*, unsigned) (BaseClient.cpp:1987)
==13793== by 0x80AF262: CClientTCPSocket::ProcessExtPacket(unsigned char const*, unsigned, unsigned char) (ClientTCPSocket.cpp:1379)
==13793==

==13793== Conditional jump or move depends on uninitialised value(s)
==13793== at 0x82E12A1: CryptoPP::CountWords(unsigned const*, unsigned) (CryptoPP.cpp:755)
==13793== by 0x82BCC1E: CryptoPP::Integer::WordCount() const (CryptoPP.cpp:4178)
==13793== by 0x82BCC37: CryptoPP::Integer::PositiveCompare(CryptoPP::Integer const&) const (CryptoPP.cpp:4993)
==13793== by 0x82BCCDB: CryptoPP::Integer::Compare(CryptoPP::Integer const&) const (CryptoPP.cpp:5006)
==13793== by 0x82E2A33: CryptoPP::operator>(CryptoPP::Integer const&, CryptoPP::Integer const&) (CryptoPP.h:3368)
==13793== by 0x82CF1A4: CryptoPP::Integer::Randomize(CryptoPP::RandomNumberGenerator&, CryptoPP::Integer const&, CryptoPP::Integer const&) (CryptoPP.cpp:4354)
==13793== by 0x82DF12E: CryptoPP::InvertibleRSAFunction::CalculateInverse(CryptoPP::RandomNumberGenerator&, CryptoPP::Integer const&) const (CryptoPP.cpp:7927)
==13793== by 0x809D8D3: CryptoPP::TrapdoorFunctionInverse::CalculateRandomizedInverse(CryptoPP::RandomNumberGenerator&, CryptoPP::Integer const&) const (CryptoPP.h:5003)
==13793== by 0x82CF536: CryptoPP::TF_SignerBase::SignAndRestart(CryptoPP::RandomNumberGenerator&, CryptoPP::PK_MessageAccumulator&, unsigned char*, bool) const (CryptoPP.cpp:6970)
==13793== by 0x82D1A58: CryptoPP::PK_Signer::SignMessage(CryptoPP::RandomNumberGenerator&, unsigned char const*, unsigned, unsigned char*) const (CryptoPP.cpp:697)
==13793== by 0x809A4E9: CClientCreditsList::CreateSignature(CClientCredits*, unsigned char*, unsigned char, unsigned, unsigned char, void*) (ClientCreditsList.cpp:359)
==13793== by 0x807432E: CUpDownClient::SendSignaturePacket() (BaseClient.cpp:1951)
==13793==
==13793== Conditional jump or move depends on uninitialised value(s)
==13793== at 0x82B46CF: CryptoPP::Compare(unsigned const*, unsigned const*, unsigned) (CryptoPP.cpp:1755)
==13793== by 0x82BCC78: CryptoPP::Integer::PositiveCompare(CryptoPP::Integer const&) const (CryptoPP.cpp:4996)
==13793== by 0x82BCCDB: CryptoPP::Integer::Compare(CryptoPP::Integer const&) const (CryptoPP.cpp:5006)
==13793== by 0x82E2A33: CryptoPP::operator>(CryptoPP::Integer const&, CryptoPP::Integer const&) (CryptoPP.h:3368)
==13793== by 0x82CF1A4: CryptoPP::Integer::Randomize(CryptoPP::RandomNumberGenerator&, CryptoPP::Integer const&, CryptoPP::Integer const&) (CryptoPP.cpp:4354)
==13793== by 0x82DF12E: CryptoPP::InvertibleRSAFunction::CalculateInverse(CryptoPP::RandomNumberGenerator&, CryptoPP::Integer const&) const (CryptoPP.cpp:7927)
==13793== by 0x809D8D3: CryptoPP::TrapdoorFunctionInverse::CalculateRandomizedInverse(CryptoPP::RandomNumberGenerator&, CryptoPP::Integer const&) const (CryptoPP.h:5003)
==13793== by 0x82CF536: CryptoPP::TF_SignerBase::SignAndRestart(CryptoPP::RandomNumberGenerator&, CryptoPP::PK_MessageAccumulator&, unsigned char*, bool) const (CryptoPP.cpp:6970)
==13793== by 0x82D1A58: CryptoPP::PK_Signer::SignMessage(CryptoPP::RandomNumberGenerator&, unsigned char const*, unsigned, unsigned char*) const (CryptoPP.cpp:697)
==13793== by 0x809A4E9: CClientCreditsList::CreateSignature(CClientCredits*, unsigned char*, unsigned char, unsigned, unsigned char, void*) (ClientCreditsList.cpp:359)
==13793== by 0x807432E: CUpDownClient::SendSignaturePacket() (BaseClient.cpp:1951)
==13793== by 0x8074613: CUpDownClient::ProcessPublicKeyPacket(unsigned char const*, unsigned) (BaseClient.cpp:1987)


No tags attached.
Issue History
2007-05-24 15:13frederichNew Issue
2007-05-24 15:13frederichOperating System => Any
2007-05-29 03:43KryStatusnew => assigned
2007-05-29 03:43KryAssigned To => Kry
2008-03-24 23:40KryStatusassigned => closed
2008-03-24 23:40KryNote Added: 0002769

Notes
(0002769)
Kry   
2008-03-24 23:40   
We use external crypto now.