aMule Bug Tracker - aMule
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001681aMuleMessagespublic2011-07-22 07:132014-09-08 22:50
Reporterbill lee 
Assigned ToGonoszTopi 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product VersionSVN 
Target VersionFixed in Version2.3.2 
Fixed in Revision10836
Operating SystemAny
Summary0001681: A reimplemention of CLogger::AddLogLine discards DebugType
DescriptionA reimplemention,
  void CLogger::AddLogLine(const wxString& file,
                    int line,
                    bool critical,
                    DebugType type,
                    std::ostringstream& msg)
discards the "type" when calling
  AddLogLine(file, line, critical, logStandard,
        cat.GetName() + wxT(": ") + char2unicode(msg.str().c_str()));
I think the "logStandard" should be replaced by "type".
Steps To Reproduce
Additional InformationThis reimplemention is called frequently in UPnPBase.cpp so aMule logs a great amount of verbose debug log even if UPnP debuging is NOT enabled.
The code is in Logger.cpp:166.
BTW, this reimplemention does a check which is also done in
  void CLogger::AddLogLine(
        const wxString& DEBUG_ONLY(file),
        int DEBUG_ONLY(line),
        bool critical,
        DebugType type,
        const wxString &str,
        bool toStdout,
        bool toGUI)
So this check will be done twice unnecessarily.
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-07-22 07:13bill leeNew Issue
2011-07-22 07:13bill leeOperating System => Any
2014-09-08 22:50GonoszTopiFixed in Revision => 10836
2014-09-08 22:50GonoszTopiAssigned To => GonoszTopi
2014-09-08 22:50GonoszTopiStatusnew => resolved
2014-09-08 22:50GonoszTopiResolutionopen => fixed
2014-09-08 22:50GonoszTopiFixed in Version => 2.3.2

There are no notes attached to this issue.