aMule Bug Tracker - aMule
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001712aMuleMiscpublic2012-03-12 14:552012-03-22 22:01
Reportergibboris 
Assigned To 
PrioritynormalSeverityfeatureReproducibilityalways
StatusnewResolutionopen 
PlatformOSOS Version
Product VersionSVN 
Target VersionFixed in Version 
Fixed in Revision
Operating SystemAny
Summary0001712: Optional GeoIp update/bundle
Descriptionhttp://forum.amule.org/index.php?topic=18910.msg102579 [^]

Mostly the optionality check should be inside CIP2Country::Enable

But there's a
CamuleDlg::IP2CountryDownloadFinished
which only wraps:
CIP2Country::DownloadFinished

If there are no strong reason for that, then handling the database once fully downloaded should happens in src/IP2Country.cpp itself so disabling it when wanted can be straightforward.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch 1712-geoip-optional-update.patch (2,232) 2012-03-12 14:58
https://bugs.amule.org/file_download.php?file_id=356&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-03-12 14:55gibborisNew Issue
2012-03-12 14:55gibborisOperating System => Any
2012-03-12 14:58gibborisFile Added: 1712-geoip-optional-update.patch
2012-03-12 14:58gibborisNote Added: 0003610
2012-03-20 22:39sturedmanNote Added: 0003615
2012-03-21 10:07gibborisNote Added: 0003619
2012-03-22 22:01sturedmanNote Added: 0003620

Notes
(0003610)
gibboris   
2012-03-12 14:58   
The attached patch may be a good starting point.
But I'm stuck on going further because of [0001086] which should, IMHO, be considered as CRITICAL !
(0003615)
sturedman   
2012-03-20 22:39   
Now why would you not want GeoIP to auto-update?

And we are not moving to a different Gui designer.
(0003619)
gibboris   
2012-03-21 10:07   
GeoIP is not this kind of thing for which users need strongly to be on the bleeding edge.
I'm fine with a 1y or even 3y old DB.

About [0001086], do you consider amule as FLOSS if we, users, can't even modify such simple elements of the GUI ?
(0003620)
sturedman   
2012-03-22 22:01   
You did not explain why the update would hurt you.

I do not like wxDesigner that much either (because you can't properly version, let alone merge .wdr), but at the current stage of the project a switch to a different GUI designer is not going to happen.
Anyway, this is a bug tracker, not a forum. The forum is where this kind (well, any kind) of discussion belongs.