aMule Bug Tracker - aMule
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000300aMuleMiscpublic2005-02-17 16:322005-02-18 11:44
Reporterphoenix 
Assigned Tophoenix 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformAthlon XP 2600+OSFedora Core LinuxOS VersionFC3
Product VersionSVN 
Target VersionFixed in Version 
Fixed in Revision
Operating System
Summary0000300: Problem with amuleweb listening port
Descriptionamuleweb is failing to grab the listening port, even when the specified value is the default, but then it tries the default value and manages to get it:

$ amuleweb -f

Creating client...
Now, doing connection....
Using host 'localhost' port:4712
Trying to connect (timeout = 10 sec)...
Succeeded! Connection established to aMule CVS

---------------------------------
| aMule Web Server |
---------------------------------


Use 'Help' for command list

WSThread: Could not get web server port -- using default value.Web Server: Started

WSThread: Thread started
WSThread: created service
aMuleweb$ WSThread: created socket listening on :4711
Steps To Reproduce
Additional InformationI have assigned it to the IRC user that reported it, his nick is KoMpLoT, will give him a few days to see if he can figure it out, he said he would try to do a patch.
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2005-02-17 16:32phoenixNew Issue
2005-02-17 16:32phoenixStatusnew => confirmed
2005-02-17 21:03komplotNote Added: 0000648
2005-02-18 11:44phoenixStatusconfirmed => resolved
2005-02-18 11:44phoenixResolutionopen => fixed
2005-02-18 11:44phoenixAssigned To => phoenix
2005-02-18 11:44phoenixNote Added: 0000650
2005-02-18 11:44phoenixStatusresolved => closed

Notes
(0000648)
komplot   
2005-02-17 21:03   
I believe the problem is in the way amuleweb retrieves the password from ~/.eMule.
You might want to check:
src/WebServer.cpp starting at line 252 (GetWSPrefs)
I believe that the If statement on line 266
 if (wsprefs && (tag = wsprefs->GetTagByName(EC_TAG_WEBSERVER_PORT)) ) {
                wsport = tag->GetInt16Data();
        } else {
                return 0;
        }
might be part of the problem or, the problem might be in
src/WebSocket.cpp starting at line 41 where CWSThread receives as a parameter CWebServer *ws and inside of the function it tries to receive the wsport using ws->GetWSPrefs so GetWSPrefs is returning a wsport=0 and then it sets the port to the default one.

I might be wrong, because I don't know how aMule really works, but in some parts of the code there's a way to get the preferences from ~/.eMule and then there's this different way used on amuleweb. I really don't know if that might be important for this bug.

As said before, I believe the problem is on src/WebServer.cpp because it just isn't getting the information correctly.

The problem now is that I don't figure out how to make a patch for that. :S
Hope someone can do this quickly, because this error doesn't only ignores the port set by the user on the config file, but also the passwords set to manage amuleweb.
Thanks!
(0000650)
phoenix   
2005-02-18 11:44   
lfroen has just fixed it.