aMule Bug Tracker - aMule
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000540aMuleFeature Requestpublic2005-08-17 17:442008-07-14 15:10
Reporterhphde 
Assigned ToXaignar 
PrioritynormalSeveritytweakReproducibilityN/A
StatusclosedResolutionopen 
PlatformOSOS Version
Product Version2.0.3 
Target VersionFixed in Version 
Fixed in Revision
Operating System
Summary0000540: Little enhanced sources dropping
DescriptionI just searched the board for this and found http://forum.amule.org/thread.php?threadid=3220 [^] but I don't know if that has been implemented yet. I found no FR for it ...

Anyway I have another FR for Sources Dropping which is easier to implement:
a) exclude files from dropping with sources < x
b) tag files to be excluded from sources dropping

The feature would come in handy when downloading files with tons of sources and others with a few (that rare feature doesn't help in this case)
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2005-08-17 17:44hphdeNew Issue
2005-12-01 10:33hphdeNote Added: 0001526
2005-12-02 02:55KryNote Added: 0001528
2005-12-02 02:58XaignarStatusnew => assigned
2005-12-02 02:58XaignarAssigned To => Xaignar
2005-12-02 02:58XaignarNote Added: 0001529
2005-12-02 03:01KryNote Added: 0001530
2005-12-02 03:03XaignarNote Added: 0001531
2005-12-02 15:49hphdeNote Added: 0001534
2005-12-03 09:14hphdeNote Added: 0001542
2008-07-14 15:10WuischkeStatusassigned => closed

Notes
(0001526)
hphde   
2005-12-01 10:33   
A developers comment would be fine ...
(0001528)
Kry   
2005-12-02 02:55   
*yawn* I don't even find sources dropping useful at all, so I'm not much concerned about it.

How's that for a developer comment?
(0001529)
Xaignar   
2005-12-02 02:58   
Ignore Kry. ;)
Personally, I'd rather change swapping/dropping to happen transparently, so that there is no need for the user to fiddle with settings. I'll look at it once 2.1.0 is out.
(0001530)
Kry   
2005-12-02 03:01   
I'd rather have no dropping at all. it's stupid and pointless. Sources always come back, so it only wastes bandwith.


The only useful dropping is sending a NNP source to an A4AF where it might be more useful. That's all.
(0001531)
Xaignar   
2005-12-02 03:03   
The DeadSourcesList helps prevents sources from comming back before they have any chances getting needed parts. But in any case, I'll agree that source-swapping is more important.
(0001534)
hphde   
2005-12-02 15:49   
Mh, okay, maybe telling this sources dropping was not so brilliant.
I was talking about the menue point "Sources Dropping" that allows more then just dropping but also sending sources (which makes sense) to other files etc.

Eg. you have a file with maybe 5000 people distributing it. Your hard limit is set to 600 you would get 600 sources and that's it. So if it would drop (send to other) sources it would have the chance to crawl the other more promising sources (not full, not queue rating >n) instead of just waiting for the 600 it first found. So far "sources sending" makes sense IMHO.

So if you activate that feature you will have a problem with all files that have sources less then "hard limit" because it's actually not a wide spread file. So we are back to my request ...
a) exclude files from dropping with sources < n (where n is maybe = "hard limit" and this is really easy to implement, maybe I should check the source with my rusty old C skills ;-) )
b) tag files to be excluded from sources dropping/sending (optional)

Thanks for the discussion anyway.
(0001542)
hphde   
2005-12-03 09:14   
Slept a night over it. Maybe you should call the menu entry "Sources Handling" instead of "Sources Dropping". That would more closely reflect what it's supposed to be.