0000900: amuled saves preferences files every minute, it should not do that

(0002007)
JusTiCe8 (reporter)
2006-05-26 12:32

in amule.cpp : void CamuleApp::OnCoreTimer(CTimerEvent& WXUNUSED(evt))

if (msCur-msPrevSave >= 60000) {
        msPrevSave = msCur;
        wxString buffer;

// Save total upload/download to preferences
        wxConfigBase* cfg = wxConfigBase::Get();
        buffer = CFormat(wxT("%llu")) % (theStats::GetSessionReceivedBytes() + thePrefs::GetTotalDownloaded());
        cfg->Write(wxT("/Statistics/TotalDownloadedBytes"), buffer);

        buffer = CFormat(wxT("%llu")) % (theStats::GetSessionSentBytes() + thePrefs::GetTotalUploaded());
        cfg->Write(wxT("/Statistics/TotalUploadedBytes"), buffer);

        // Write changes to file
        cfg->Flush();

In fact, some stuff like stats should not be stored in preferences files !

(0002008)
Kry (manager)
2006-05-27 10:35

But it is! And can't be taken off there!

(0002012)
JusTiCe8 (reporter)
2006-05-29 11:23

too bad.

(0002014)
Kry (manager)
2006-05-30 07:18

I agree.

Issue History
Date Modified	Username	Field	Change
2006-05-22 19:40	JusTiCe8	New Issue
2006-05-22 19:40	JusTiCe8	Operating System	=> Any
2006-05-26 12:32	JusTiCe8	Note Added: 0002007
2006-05-27 10:35	Kry	Note Added: 0002008
2006-05-29 11:22	JusTiCe8	Note Added: 0002010
2006-05-29 11:22	JusTiCe8	Note Added: 0002011
2006-05-29 11:23	JusTiCe8	Note Added: 0002012
2006-05-29 17:45	JusTiCe8	Note Deleted: 0002011
2006-05-29 17:45	JusTiCe8	Note Deleted: 0002010
2006-05-30 07:18	Kry	Note Added: 0002014
2006-09-09 09:33	GonoszTopi	Status	new => assigned
2006-09-09 09:33	GonoszTopi	Assigned To	=> GonoszTopi
2008-07-14 17:44	Wuischke	Status	assigned => closed

Notes
(0002007) JusTiCe8 (reporter) 2006-05-26 12:32	in amule.cpp : void CamuleApp::OnCoreTimer(CTimerEvent& WXUNUSED(evt)) if (msCur-msPrevSave >= 60000) { msPrevSave = msCur; wxString buffer; // Save total upload/download to preferences wxConfigBase* cfg = wxConfigBase::Get(); buffer = CFormat(wxT("%llu")) % (theStats::GetSessionReceivedBytes() + thePrefs::GetTotalDownloaded()); cfg->Write(wxT("/Statistics/TotalDownloadedBytes"), buffer); buffer = CFormat(wxT("%llu")) % (theStats::GetSessionSentBytes() + thePrefs::GetTotalUploaded()); cfg->Write(wxT("/Statistics/TotalUploadedBytes"), buffer); // Write changes to file cfg->Flush(); In fact, some stuff like stats should not be stored in preferences files !

(0002008) Kry (manager) 2006-05-27 10:35	But it is! And can't be taken off there!

(0002012) JusTiCe8 (reporter) 2006-05-29 11:23	too bad.

(0002014) Kry (manager) 2006-05-30 07:18	I agree.

Relationships