0001030: wrong placing of "Unkown" items while sorting of the "Time Remaining" column

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001030

aMule

Feature Request

public

2006-12-18 11:49

2008-07-09 16:16

Reporter

bart9h

Assigned To

Priority

normal

Severity

feature

Reproducibility

always

Status

closed

Resolution

open

Platform

OS Version

Product Version

2.1.3

Target Version

Fixed in Version

Summary

0001030: wrong placing of "Unkown" items while sorting of the "Time Remaining" column

Description

On the "Transfers" view, when sorting by the "Time Remaining" column, the user wants to watch the files that will arrive first, so the "Unknown" items should be placed after the others, not before.

The included patch, against the 2.1.3 version, does that.

Additional Information

$diff -u aMule-2.1.3/src/DownloadListCtrl.cpp aMule-2.1.3/src/DownloadListCtrl.cpp.barrett9h
--- aMule-2.1.3/src/DownloadListCtrl.cpp 2006-03-10 02:02:41.000000000 -0300
+++ aMule-2.1.3/src/DownloadListCtrl.cpp.barrett9h 2006-12-18 08:38:05.000000000 -0200
@@ -1909,11 +1909,11 @@
                        if (file2->getTimeRemaining() == -1) {
                                result = 0;
                        } else {
- result = -1;
+ result = 1;
                        }
                } else {
                        if (file2->getTimeRemaining() == -1) {
- result = 1;
+ result = -1;
                        } else {
                                result = CmpAny(
                                        file1->getTimeRemaining(),

Issue History
Date Modified	Username	Field	Change
2006-12-18 11:49	bart9h	New Issue
2006-12-18 11:49	bart9h	Operating System	=> Any
2008-07-09 16:16	Wuischke	Status	new => closed

Relationships

Notes
There are no notes attached to this issue.