0001700: amuleweb crash on CProgressImage::CreateSpan

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001700

aMule

GUI

public

2011-12-03 19:34

2012-02-11 19:14

Reporter

TeddyBeer

Assigned To

Priority

normal

Severity

crash

Reproducibility

sometimes

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

SVN

Target Version

Fixed in Version

2.3.2

Summary

0001700: amuleweb crash on CProgressImage::CreateSpan

Description

When viewing the Transfer page in the web-gui for some minutes (15-20min) the amuleweb crashes (the page refresh itself 3-4 times a minutes) and must be restarted.

I don't have the full backtrace here, but they are quite the same as the one reported in the issue: 0001652

I'm on the latest SVN release (10686).

I've experienced the issue running the amuleweb on a QNAP-linux (arm CPU) and on my laptop either (ubuntu 11.10).

amuled is at the same version as the amuleweb.

---
a quick & dirty working patch seems to be this one (at least for me):

Index: src/webserver/src/WebServer.cpp
===================================================================
--- src/webserver/src/WebServer.cpp (revision 10686)
+++ src/webserver/src/WebServer.cpp (working copy)
@@ -1067,7 +1067,10 @@
                for(int i = 1; i <= colored_gaps_size;i++) {
                        uint32 start = colored_gaps[i].start / factor;
                        uint32 end = colored_gaps[i].end / factor;
- for(uint32 j = start; j < end; j++) {
+ if(end > m_width){
+ end=m_width;
+ }
+ for(uint32 j = start; j < end ; j++) {
                                m_ColorLine[j] = colored_gaps[i].color;
                        }
                }
@@ -1075,7 +1078,11 @@
                for(uint32 i = 0; i < m_file->m_ReqParts.size(); i++) {
                        uint32 start = m_file->m_ReqParts[i].start / factor;
                        uint32 end = m_file->m_ReqParts[i].end / factor;
- for(uint32 j = start; j < end; j++) {
+ if(end > m_width){
+ end=m_width;
+ }
+ for(uint32 j = start; j < end ; j++) {
+
                                m_ColorLine[j] = RGB(255, 208, 0);
                        }
                }

Additional Information

compiled from:
svn 10686
wxWidgets 2.8.12

Tags

No tags attached.

Fixed in Revision

10755

Operating System

ubuntu 11.10 / qnap-firmware (linux)

Attached Files

Relationships

Notes
(0003591) TeddyBeer (reporter) 2011-12-03 19:51	i didn't attached the patch as an attachement because it's not yet considerable a real patch, because of some randomic weirdness generated in the images, but at least seems to stop the crashes.

(0003604) sturedman (developer) 2012-02-11 19:14	Applied your patch, thank you!

Issue History
Date Modified	Username	Field	Change
2011-12-03 19:34	TeddyBeer	New Issue
2011-12-03 19:34	TeddyBeer	Operating System	=> ubuntu 11.10 / qnap-firmware (linux)
2011-12-03 19:51	TeddyBeer	Note Added: 0003591
2012-02-11 19:14	sturedman	Fixed in Revision	=> 10755
2012-02-11 19:14	sturedman	Note Added: 0003604
2012-02-11 19:14	sturedman	Status	new => resolved
2012-02-11 19:14	sturedman	Resolution	open => fixed
2012-02-11 19:14	sturedman	Fixed in Version	=> 2.3.2