0001715: Can't build on fedora 17

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001715

aMule

Misc

public

2012-04-03 13:52

2012-05-12 07:37

Reporter

brand77

Assigned To

sturedman

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

2.3.2

Summary

0001715: Can't build on fedora 17

Description

I can't build on fedora 17 with this error:

In file included from DownloadQueue.h:30:0,
from DownloadQueue.cpp:26:
ObservableQueue.h: In instantiation of ‘void CObservableQueue<ValueType>::ObserverAdded(CObservableQueue<ValueType>::ObserverType*) [with ValueType = CPartFile*; CObservableQueue<ValueType>::ObserverType = CObserver<CQueueEvent<CPartFile*> >]':
DownloadQueue.cpp:1528:32: required from here
ObservableQueue.h:334:2: error: ‘NotifyObservers' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
ObservableQueue.h:334:2: note: declarations in dependent base ‘CObservable<CQueueEvent<CPartFile*> >' are not found by unqualified lookup
ObservableQueue.h:334:2: note: use ‘this->NotifyObservers' instead
ObservableQueue.h: In instantiation of ‘void CObservableQueue<ValueType>::ObserverRemoved(CObservableQueue<ValueType>::ObserverType*) [with ValueType = CPartFile*; CObservableQueue<ValueType>::ObserverType = CObserver<CQueueEvent<CPartFile*> >]':
DownloadQueue.cpp:1665:1: required from here
ObservableQueue.h:341:2: error: ‘NotifyObservers' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
ObservableQueue.h:341:2: note: declarations in dependent base ‘CObservable<CQueueEvent<CPartFile*> >' are not found by unqualified lookup
ObservableQueue.h:341:2: note: use ‘this->NotifyObservers' instead
make[3]: *** [amule-DownloadQueue.o] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

This little patch solve the problem:

diff aMule-2.3.1/src/ObservableQueue.h.old aMule-2.3.1/src/ObservableQueue.h
334c334
< NotifyObservers( EventType( EventType::STARTING ), o );
---
> this->NotifyObservers( EventType( EventType::STARTING ), o );
341c341
< NotifyObservers( EventType( EventType::STOPPING ), o );
---
> this->NotifyObservers( EventType( EventType::STOPPING ), o );

Additional Information

The problem is GCC 4.7, not Fedora.

Tags

No tags attached.

Fixed in Revision

10772

Operating System

Any

Attached Files

Relationships

has duplicate

0001718

resolved

sturedman

unable to compile

Notes
(0003623) brand77 (reporter) 2012-04-03 13:54	wrong category, nothing to do with GUI... how to move?

(0003624) sturedman (developer) 2012-04-11 16:19	Thank you!

Issue History
Date Modified	Username	Field	Change
2012-04-03 13:52	brand77	New Issue
2012-04-03 13:52	brand77	Operating System	=> Any
2012-04-03 13:54	brand77	Note Added: 0003623
2012-04-11 16:19	sturedman	Fixed in Revision	=> 10772
2012-04-11 16:19	sturedman	Note Added: 0003624
2012-04-11 16:19	sturedman	Assigned To	=> sturedman
2012-04-11 16:19	sturedman	Status	new => resolved
2012-04-11 16:19	sturedman	Resolution	open => fixed
2012-04-11 16:19	sturedman	Category	GUI => Misc
2012-04-11 16:19	sturedman	Additional Information Updated
2012-05-12 07:37	GonoszTopi	Fixed in Version	=> 2.3.2
2012-05-12 07:38	GonoszTopi	Relationship added	has duplicate 0001718