0000399: All-time-requests for part-files is always zero

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000399

aMule

Sharedfiles

public

2005-04-26 08:50

2005-04-26 16:49

Reporter

eyalzo

Assigned To

Kry

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

open

Platform

OS Version

Product Version

2.0.0-rc8

Target Version

Fixed in Version

Summary

0000399: All-time-requests for part-files is always zero

Description

I have noticed that all part files in shared-files list, shows 0 on the Requests column, even when I had many requests in previous runs.
This bug was found in CDownloadQueue::Init()
There is a loop that loads all part files, without checking if it's a known file (known.met).
I found a way to fix it, by adding a couple of Setters like SetAllTimeRequests() to KnownFile.h, and use them in the Init() method I have mentioned here. For example:

        if (result) {
            const CKnownFile* knownFile = theApp.knownfiles->FindKnownFileByID(toadd->GetFileHash());
            if ( knownFile )
                toadd->statistic.SetAllTimeRequests(knownFile->statistic.GetAllTimeRequests());

Tags

No tags attached.

Fixed in Revision

Operating System

Attached Files

Relationships

Notes
(0000918) GonoszTopi (administrator) 2005-04-26 10:15	If you have a fix for the problem, why don't you upload the patch, then we wouldn't have to reinvent the wheel :) And, for bug reports and patches please use CVS version. rc8 is way too old now ;p

(0000923) eyalzo (reporter) 2005-04-26 16:11	Sorry. I'm new here... Meantime, I found a better way to save the all-time counters. I simply add them to part.met files, as tags, just like in known.met. I will update the patch, but I need to know first if this feature sounds reasonable. I think it is, because it's interesting to know how many requests were sent to your part files, even if you restart aMule once in a while.

(0000924) Kry (manager) 2005-04-26 16:49	This is done since 2 days ago in CVS Too late... ;) But many thanks :)

Issue History
Date Modified	Username	Field	Change
2005-04-26 08:50	eyalzo	New Issue
2005-04-26 10:15	GonoszTopi	Note Added: 0000918
2005-04-26 16:11	eyalzo	Note Added: 0000923
2005-04-26 16:48	Kry	Status	new => assigned
2005-04-26 16:48	Kry	Assigned To	=> Kry
2005-04-26 16:49	Kry	Status	assigned => closed
2005-04-26 16:49	Kry	Note Added: 0000924