0001199: amulecmd: search type is always GLOBAL (CVS 20071112)

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001199

aMule

External Conn

public

2007-11-13 00:48

2007-11-22 15:04

Reporter

mr_hyde

Assigned To

Wuischke

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

SVN

Target Version

Fixed in Version

Summary

0001199: amulecmd: search type is always GLOBAL (CVS 20071112)

Description

The search type assumed by amulecmd is always GLOBAL.
You can simly verify this starting only KAD network (so NOT ed2k) and trying to execute a

search kad something

In this case you obtain only the message

Request failed with the following error: ED2K search can't be done if ED2K is not connected

HOW TO FIX THIS:
Edit file src/TextClient.cpp and change

int CamulecmdApp::ProcessCommand(int CmdId)
{
    wxString args = GetCmdArgs();
    CECPacket *request = 0;
    std::list<CECPacket *> request_list;
    int tmp_int = 0;
    EC_SEARCH_TYPE search_type;

as follows (added initialization for "search_type"):

int CamulecmdApp::ProcessCommand(int CmdId)
{
    wxString args = GetCmdArgs();
    CECPacket *request = 0;
    std::list<CECPacket *> request_list;
    int tmp_int = 0;
    EC_SEARCH_TYPE search_type = EC_SEARCH_KAD; //Mr Hyde: added initilization

Tags

No tags attached.

Fixed in Revision

Operating System

Any

Attached Files

Relationships

Notes
(0002437) mr_hyde (reporter) 2007-11-13 00:50 edited on: 2007-11-13 00:57	Probably this is the same error described in 0001195 edited on: 11-13-07 00:57

(0002457) Wuischke (manager) 2007-11-18 14:32	Committed, thank you. Please test it again with tomorrow's tarball and report back.

(0002459) mr_hyde (reporter) 2007-11-20 19:54	Seems fixed now (tried with CVS 20071120). Thanks, Mr Hyde

Issue History
Date Modified	Username	Field	Change
2007-11-13 00:48	mr_hyde	New Issue
2007-11-13 00:48	mr_hyde	Operating System	=> Any
2007-11-13 00:50	mr_hyde	Note Added: 0002437
2007-11-13 00:57	mr_hyde	Note Edited: 0002437
2007-11-18 14:32	Wuischke	Note Added: 0002457
2007-11-18 14:55	Wuischke	Status	new => feedback
2007-11-20 19:54	mr_hyde	Note Added: 0002459
2007-11-22 15:04	Wuischke	Status	feedback => resolved
2007-11-22 15:04	Wuischke	Resolution	open => fixed
2007-11-22 15:04	Wuischke	Assigned To	=> Wuischke