0001207: Keyboard events (DELETE, ARROW KEYS pressed) not managed in some list control

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001207

aMule

Misc

public

2007-11-22 07:55

2008-01-06 14:47

Reporter

mr_hyde

Assigned To

Xaignar

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

SVN

Target Version

Fixed in Version

Summary

0001207: Keyboard events (DELETE, ARROW KEYS pressed) not managed in some list control

Description

See http://forum.amule.org/index.php?topic=13788.0. [^]

Some list controls such as download list, upload list and shared file list have not the focus so it is not possible to use cursor arrow keys to move the current selection or the DELETE key to cancel the current download.

With the following workaround the focus is restored.
[from the forum development section]

Edit file src/extern/wxWidgets/listctrl.cpp and change

void wxListMainWindow::ChangeCurrent(size_t current)
{
    m_current = current;
    SendNotify(current, wxEVT_COMMAND_LIST_ITEM_FOCUSED);
}

in

void wxListMainWindow::ChangeCurrent(size_t current)
{
    m_current = current;
    SetFocus(); // Mr Hyde - added to restore focus and keyboar events management
    SendNotify(current, wxEVT_COMMAND_LIST_ITEM_FOCUSED);
}

Please consider this as a WORKAROUND and NOT as a "final fix": I don't know well wxWidgets, I don't own a MAC (so I can't observe the results of this changes for a MAC) and probably a "more elegant" solution exist!

I made this change in CVS 20071120.

I noticed the problem using wxWidgets 2.8.6 and SLAMD64 current, with KDE.

Bye,
  Mr Hyde

Tags

No tags attached.

Fixed in Revision

Operating System

Any

Attached Files

Relationships

Notes
(0002482) mr_hyde (reporter) 2007-12-31 16:03	Seems to work correctly in 20071231. Thanks, Mr Hyde

(0002486) Xaignar (manager) 2008-01-06 14:47	Ok, thanks for reporting the problem.

Issue History
Date Modified	Username	Field	Change
2007-11-22 07:55	mr_hyde	New Issue
2007-11-22 07:55	mr_hyde	Operating System	=> Any
2007-12-31 16:03	mr_hyde	Note Added: 0002482
2008-01-06 14:47	Xaignar	Status	new => resolved
2008-01-06 14:47	Xaignar	Resolution	open => fixed
2008-01-06 14:47	Xaignar	Assigned To	=> Xaignar
2008-01-06 14:47	Xaignar	Note Added: 0002486