0000249: On Mac, browers doesn't work - aMule Bug Tracker

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0000249

aMule

Misc

public

2005-01-07 04:44

2005-04-24 15:33

Reporter

Kry

Assigned To

ken

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS

OS Version

Product Version

2.0.0-rc8

Target Version

Fixed in Version

SVN

Summary

0000249: On Mac, browers doesn't work

Description

Browser selection doesn't work at all on Mac. Well, selection does, but running them doesn't.

Additional Information

There's some nice code hanging around since long time ago, now removed:

#ifdef __WXMAC__

         #if 0
         // Kry -Uh?
         wxString url1(url);
         if (url1.Left(5) != wxT("file:"))
                 url1 = wxNativePathToURL(url1);

         OSStatus err;
         ICInstance inst;
         SInt32 startSel;
         SInt32 endSel;

         err = ICStart(&inst, 'STKA'); // put your app creator code here
         if (err == noErr) {
                 #if !TARGET_CARBON
                 err = ICFindConfigFile(inst, 0, nil);
                 #endif
                 if (err == noErr) {
                 startSel = 0;
                 endSel = wxStrlen(url1);
                 err = ICLaunchURL(inst, "\p", url1, endSel, &startSel, &endSel);
                 }
                 ICStop(inst);
         }
         #endif

Can someone make sense of it? ken?

Tags

No tags attached.

Fixed in Revision

Operating System

Relationships

Notes
(0000496) blue_eclipse (reporter) 2005-01-07 14:16	Mozilla Firefox works for me, Safari doesn't (Mac OS X 10.3.7)

(0000906) ken (developer) 2005-04-24 15:33	In CVS, browser defaults to User Defined and Custom Browser defaults to "/usr/bin/open". This will launch the user's configured default browser. Also, with wxMac-cvs, if the user sets Custom Browser to the path to the .app bundle (e.g. "/Applications/Safari.app") it will work properly. There's little hope of getting it to work on the Mac the same way it works on other platforms, where the user picks their browser from the pop-up menu instead of User Defined. That relies on the browser either being on the PATH or being in a well-known absolute location. The only browsers in well-known locations on the Mac are Safari and (shudder) Internet Explorer. We could add Safari to the pop-up, I suppose. For that matter, we could add an entry titled "Mac Default Browser" which maps to "/usr/bin/open" instead of the kludge I committed. However, that would require somebody with access to wxDesigner.

Issue History
Date Modified	Username	Field	Change
2005-01-07 04:44	Kry	New Issue
2005-01-07 04:45	Kry	Status	new => assigned
2005-01-07 04:45	Kry	Assigned To	=> ken
2005-01-07 04:47	Kry	Category	Feature Request => Misc
2005-01-07 14:16	blue_eclipse	Note Added: 0000496
2005-04-24 15:33	ken	Status	assigned => resolved
2005-04-24 15:33	ken	Fixed in Version	=> CVS
2005-04-24 15:33	ken	Resolution	open => fixed
2005-04-24 15:33	ken	Note Added: 0000906

Copyright © 2000 - 2024 MantisBT Team