0000709: statistics item wrongly coded

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000709

aMule

External Conn

public

2005-12-09 09:39

2005-12-09 23:27

Reporter

Jacobo221

Assigned To

Kry

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0000709: statistics item wrongly coded

Description

Statistics has an item in the tree which is titled "HasSocket". It is supposed to show the number of clients which have been assigned a socket, but it doesn't work.

It's count is incremented and decremented from SetSocket(). This function is correctly called when destrying sockets, but not when creating them:

CUpDownClient::CUpDownClient(CClientTCPSocket* sender)
{
#ifdef __DEBUG__
        m_socket = NULL;
        SetSocket(sender);
#else
        m_socket = sender;
#endif
        Init();
}

It will only called in Debug builds.

Consutrctor CUpDownClient::CUpDownClient(uint16 in_port, uint32 in_userid, uint32 in_serverip, uint16 in_serverport, CPartFile* in_reqfile, bool ed2kID, bool checkfrien
d) coesn't call SetSocket(), but I'm don't know if it should. Actually I think it is ok not calling it.

Tags

No tags attached.

Fixed in Revision

Operating System

Attached Files

Relationships

Notes
(0001606) Kry (manager) 2005-12-09 23:23	HasSocket() must only be shown on debug, as it's basically for me. And so I coded it.

(0001607) Kry (manager) 2005-12-09 23:27	#ifdef __DEBUG__ s_hasSocket = (CStatTreeItemNativeCounter*)s_clients->AddChild(new CStatTreeItemNativeCounter(wxT("HasSocket: %s")), 3); #endif

Issue History
Date Modified	Username	Field	Change
2005-12-09 09:39	Jacobo221	New Issue
2005-12-09 23:23	Kry	Note Added: 0001606
2005-12-09 23:27	Kry	Status	new => assigned
2005-12-09 23:27	Kry	Assigned To	=> Kry
2005-12-09 23:27	Kry	Status	assigned => closed
2005-12-09 23:27	Kry	Note Added: 0001607