0001681: A reimplemention of CLogger::AddLogLine discards DebugType

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001681

aMule

Messages

public

2011-07-22 07:13

2014-09-08 22:50

Reporter

bill lee

Assigned To

GonoszTopi

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

SVN

Target Version

Fixed in Version

2.3.2

Summary

0001681: A reimplemention of CLogger::AddLogLine discards DebugType

Description

A reimplemention,
  void CLogger::AddLogLine(const wxString& file,
                    int line,
                    bool critical,
                    DebugType type,
                    std::ostringstream& msg)
discards the "type" when calling
  AddLogLine(file, line, critical, logStandard,
        cat.GetName() + wxT(": ") + char2unicode(msg.str().c_str()));
I think the "logStandard" should be replaced by "type".

Additional Information

This reimplemention is called frequently in UPnPBase.cpp so aMule logs a great amount of verbose debug log even if UPnP debuging is NOT enabled.
The code is in Logger.cpp:166.
BTW, this reimplemention does a check which is also done in
  void CLogger::AddLogLine(
        const wxString& DEBUG_ONLY(file),
        int DEBUG_ONLY(line),
        bool critical,
        DebugType type,
        const wxString &str,
        bool toStdout,
        bool toGUI)
So this check will be done twice unnecessarily.

Tags

No tags attached.

Fixed in Revision

10836

Operating System

Any

Attached Files

Relationships

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2011-07-22 07:13	bill lee	New Issue
2011-07-22 07:13	bill lee	Operating System	=> Any
2014-09-08 22:50	GonoszTopi	Fixed in Revision	=> 10836
2014-09-08 22:50	GonoszTopi	Assigned To	=> GonoszTopi
2014-09-08 22:50	GonoszTopi	Status	new => resolved
2014-09-08 22:50	GonoszTopi	Resolution	open => fixed
2014-09-08 22:50	GonoszTopi	Fixed in Version	=> 2.3.2