Anonymous | Login | Signup for a new account | 2024-10-11 11:13 CEST |
My View | View Issues | Change Log | Roadmap |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
0001712 | aMule | Misc | public | 2012-03-12 14:55 | 2012-03-22 22:01 | ||||||||
Reporter | gibboris | ||||||||||||
Assigned To | |||||||||||||
Priority | normal | Severity | feature | Reproducibility | always | ||||||||
Status | new | Resolution | open | ||||||||||
Platform | OS | OS Version | |||||||||||
Product Version | SVN | ||||||||||||
Target Version | Fixed in Version | ||||||||||||
Summary | 0001712: Optional GeoIp update/bundle | ||||||||||||
Description | http://forum.amule.org/index.php?topic=18910.msg102579 [^] Mostly the optionality check should be inside CIP2Country::Enable But there's a CamuleDlg::IP2CountryDownloadFinished which only wraps: CIP2Country::DownloadFinished If there are no strong reason for that, then handling the database once fully downloaded should happens in src/IP2Country.cpp itself so disabling it when wanted can be straightforward. | ||||||||||||
Tags | No tags attached. | ||||||||||||
Fixed in Revision | |||||||||||||
Operating System | Any | ||||||||||||
Attached Files | 1712-geoip-optional-update.patch [^] (2,232 bytes) 2012-03-12 14:58 [Show Content] | ||||||||||||
Notes | |
(0003610) gibboris (reporter) 2012-03-12 14:58 |
The attached patch may be a good starting point. But I'm stuck on going further because of [0001086] which should, IMHO, be considered as CRITICAL ! |
(0003615) sturedman (developer) 2012-03-20 22:39 |
Now why would you not want GeoIP to auto-update? And we are not moving to a different Gui designer. |
(0003619) gibboris (reporter) 2012-03-21 10:07 |
GeoIP is not this kind of thing for which users need strongly to be on the bleeding edge. I'm fine with a 1y or even 3y old DB. About [0001086], do you consider amule as FLOSS if we, users, can't even modify such simple elements of the GUI ? |
(0003620) sturedman (developer) 2012-03-22 22:01 |
You did not explain why the update would hurt you. I do not like wxDesigner that much either (because you can't properly version, let alone merge .wdr), but at the current stage of the project a switch to a different GUI designer is not going to happen. Anyway, this is a bug tracker, not a forum. The forum is where this kind (well, any kind) of discussion belongs. |
Issue History | |||
Date Modified | Username | Field | Change |
2012-03-12 14:55 | gibboris | New Issue | |
2012-03-12 14:55 | gibboris | Operating System | => Any |
2012-03-12 14:58 | gibboris | File Added: 1712-geoip-optional-update.patch | |
2012-03-12 14:58 | gibboris | Note Added: 0003610 | |
2012-03-20 22:39 | sturedman | Note Added: 0003615 | |
2012-03-21 10:07 | gibboris | Note Added: 0003619 | |
2012-03-22 22:01 | sturedman | Note Added: 0003620 |
Copyright © 2000 - 2024 MantisBT Team |