0000057: tray speed control - aMule Bug Tracker

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000057

aMule

Misc

public

2004-05-30 23:37

2004-08-02 15:47

Reporter

Hetfield

Assigned To

Xaignar

Priority

normal

Severity

tweak

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0000057: tray speed control

Description

If I set my DownloadCapacity to 3 and my UploadCapacity to 3,
then my ConnectionLimits are lost at aMule-Restart.

I read through the code and found two lines in SysTray.cpp
that are involved in this (line 154-155):

        if (theApp.glob_prefs->GetMaxGraphDownloadRate() <
theApp.glob_prefs->GetMaxDownload())
theApp.glob_prefs->SetDownloadlimit(UNLIMITED);
        if (theApp.glob_prefs->GetMaxGraphUploadRate() <
theApp.glob_prefs->GetMaxUpload())
theApp.glob_prefs->SetUploadlimit(UNLIMITED);

Shouldn't LineCapacity and SpeedLimit not interfere
each other (reasons are explained in the sourcecode yet)?!
In fact they do at this point.

My suggestion as replacement for these two lines, something
like:

        if (theApp.glob_prefs->GetMaxGraphDownloadRate() <
theApp.glob_prefs->GetMaxDownload())
theApp.glob_prefs->SetDownloadlimit(theApp.glob_prefs->GetMaxGraphDownloadRate());
        if (theApp.glob_prefs->GetMaxGraphUploadRate() <
theApp.glob_prefs->GetMaxUpload())
theApp.glob_prefs->SetUploadlimit(theApp.glob_prefs->GetMaxGraphUploadRate() );

reported by Andreas Brandmaier <andy@brandmaier.de>

Additional Information

the problem is that when i made the tray i couldn't access lots of functions.
now things are changed.
as u can see speed code is cut & paste from old prefs code.

please make the tray call th unified prefs code and not a cut&paste.
i can't do for time reason actually

Notes
(0000186) Xaignar (manager) 2004-08-02 15:47	Fixed. We now call the PrefsUnifiedDlg function.

Issue History
Date Modified	Username	Field	Change
2004-05-30 23:37	Hetfield	New Issue
2004-08-02 15:47	Xaignar	Status	new => resolved
2004-08-02 15:47	Xaignar	Resolution	open => fixed
2004-08-02 15:47	Xaignar	Assigned To	=> Xaignar
2004-08-02 15:47	Xaignar	Note Added: 0000186

Relationships