0000659: disconnect button might not disconnect kad and block it's function

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000659

aMule

Servers

public

2005-11-17 11:46

2005-11-18 15:17

Reporter

Jacobo221

Assigned To

Xaignar

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

SVN

Summary

0000659: disconnect button might not disconnect kad and block it's function

Description

amuleDlg.cpp (in OnBnConnect function) contains:

        // Connect Kad also
        if( disconnect && thePrefs::GetNetworkKademlia()) {
                theApp.StopKad();
        } else {
                theApp.StartKad();
        }

So, if we go to Prefs -> Connection -> Kad and disable it, then we click the disconnect button... and it is not disconnected. What's more, the connect/disconnect button will not change to Connect since Kad is still connected.

It should just check "if( disconnect )". Both StartKad() (through GetNetworkKademlia()) and StopKad() (through IsRunning()) already check Kad's status.

Tags

No tags attached.

Fixed in Revision

Operating System

Attached Files

Relationships

related to

0000658

resolved

Kry

connect/disconnect buttons ambiguous

Notes
(0001470) Xaignar (manager) 2005-11-17 15:39	We need two buttons, afaics, this is simply too funky.

(0001474) Kry (manager) 2005-11-17 17:37	No, it's ok. ED2K and Kad can be disconencted on their page. I'll just make the disconenct happen on prefs change, as for the rest, is all ok.

(0001476) Kry (manager) 2005-11-17 17:43	Commited and fixed.

(0001483) Jacobo221 (updater) 2005-11-17 20:49	this patch + if (thePrefs::GetNetworkED2K() && theApp.IsConnectedED2K()) { + theApp.serverconnect->Disconnect(); + } + + if (thePrefs::GetNetworkKademlia() && theApp.IsConnectedKad()) { + theApp.StopKad(); + } + Is obviously acting inverse to what it should do. It should be: if (!thePrefs::GetNetworkED2K() && theApp.IsConnectedED2K()) ... if (!thePrefs::GetNetworkKademlia() && theApp.IsConnectedKad())

Issue History
Date Modified	Username	Field	Change
2005-11-17 11:46	Jacobo221	New Issue
2005-11-17 11:57	Jacobo221	Category	External Conn => Servers
2005-11-17 15:39	Xaignar	Note Added: 0001470
2005-11-17 16:33	Xaignar	Relationship added	related to 0000658
2005-11-17 17:37	Kry	Note Added: 0001474
2005-11-17 17:43	Kry	Status	new => resolved
2005-11-17 17:43	Kry	Fixed in Version	=> CVS
2005-11-17 17:43	Kry	Resolution	open => fixed
2005-11-17 17:43	Kry	Assigned To	=> Kry
2005-11-17 17:43	Kry	Note Added: 0001476
2005-11-17 20:49	Jacobo221	Status	resolved => feedback
2005-11-17 20:49	Jacobo221	Resolution	fixed => reopened
2005-11-17 20:49	Jacobo221	Note Added: 0001483
2005-11-18 15:15	Jacobo221	Assigned To	Kry =>
2005-11-18 15:15	Jacobo221	Resolution	reopened => fixed
2005-11-18 15:17	Xaignar	Status	feedback => resolved
2005-11-18 15:17	Xaignar	Assigned To	=> Xaignar